Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UIE-8131] - IAM RBAC: Routes, Menu, Feature Flag #11310

Merged

Conversation

aaleksee-akamai
Copy link
Contributor

@aaleksee-akamai aaleksee-akamai commented Nov 22, 2024

Description 📝

IAM RBAC - all routes, menu, feature flag

Changes 🔄

  • new menu item
  • new feature flag
  • routes for iam

Target release date 🗓️

Dec 10, 2024 (dev)

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before After
image
image

|

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai aaleksee-akamai requested a review from a team as a code owner November 22, 2024 14:43
@aaleksee-akamai aaleksee-akamai requested review from bnussman-akamai and cpathipa and removed request for a team November 22, 2024 14:43
@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8131-iam-rbac-routes-menu branch 2 times, most recently from 3fb6fc4 to 7b7680c Compare November 22, 2024 14:51
Copy link

github-actions bot commented Nov 22, 2024

Coverage Report:
Base Coverage: 86.95%
Current Coverage: 86.96%

@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8131-iam-rbac-routes-menu branch 2 times, most recently from 4ca42f7 to 703a31b Compare December 2, 2024 11:20
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A small number of things need to be cleaned up

);
};

export default IdentityAccessManagement;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exports IdentityAccessManagement already. Let's just keep the named export and remove this default export

Suggested change
export default IdentityAccessManagement;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done

<Switch>
<Route component={UserDetails} path={`${path}/users/:username/`} />
<Redirect exact from={path} to={`${path}/users`} />
<Route component={IAMLanding} path={`${path}`} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Route component={IAMLanding} path={`${path}`} />
<Route component={IAMLanding} path={path} />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 17 to 19
type CombinedProps = RouteComponentProps;

export const IdentityAccessManagement: React.FC<CombinedProps> = (props) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can express this in a cleaner way. We aren't combining any types to we don't need a type called CombinedProps. We also don't need to use React.FC.

Suggested change
type CombinedProps = RouteComponentProps;
export const IdentityAccessManagement: React.FC<CombinedProps> = (props) => {
export const IdentityAccessManagement = (props: RouteComponentProps) => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

);
});

export default IdentityAccessManagementLanding;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can we just remove this default export and export IdentityAccessManagementLanding

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8131-iam-rbac-routes-menu branch from 703a31b to b189765 Compare December 2, 2024 16:17
@aaleksee-akamai
Copy link
Contributor Author

@bnussman-akamai , thanks, I've updated this PR

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing451 Passing2 Skipped118m 1s

Details

Failing Tests
SpecTest
machine-image-upload.spec.tsmachine image » uploads machine image, mock finish event
machine-image-upload.spec.tsmachine image » uploads machine image, mock upload canceled failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock failed to decompress failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock expired upload event

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts"

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good. confirming failed tests passed in local.
image

@cpathipa cpathipa merged commit 9afb2bc into linode:develop Dec 3, 2024
22 of 23 checks passed
Copy link

cypress bot commented Dec 3, 2024

Cloud Manager E2E    Run #6909

Run Properties:  status check passed Passed #6909  •  git commit 9afb2bc704: feat: [UIE-8131] - RBAC-1: Routes, Menu, Feature Flag (#11310)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6909
Run duration 30m 49s
Commit git commit 9afb2bc704: feat: [UIE-8131] - RBAC-1: Routes, Menu, Feature Flag (#11310)
Committer aaleksee-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 465
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants